Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGITAL-37: Migrate links paragraph templates. #48

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Nov 21, 2024

Jira ticket

DIGITAL-37

Purpose

Adds paragraph_view_mode module.
Migrate template for featured links field display. Adds separate templates for default and featured links views of resources. Updates featured links template with correct markup. Switch shortcodes to use theme templates for resources.

It can be helpful to understand:

  1. What the solution is,
  2. Why this approach was chosen,
  3. How you implemented the change
  4. Possible limitations of this approach and alternate solution paths. -->

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

bin/drush cim to get paragraph type updates
bin/drush cr to refresh theme template cache

QA/Testing instructions

Edit a topic page, add one or more internal and external resources
Confirm they use the expected HTML from the featured-links template
Override the title, summary for resources and confirm overrides are used

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@omerida omerida requested a review from mattsqd November 21, 2024 19:31
Adds paragraph_view_mode module.
Migrate template for featured links field display.
Adds separate templates for default and featured links views of resources.
Updates featured links template with correct markup.
Switch shortcodes to use theme templates for resources.
@omerida omerida force-pushed the feature/DIGITAL-37-resource-paragraphs branch from 151716b to 932bbc7 Compare November 21, 2024 19:36
mattsqd and others added 5 commits November 22, 2024 14:44
…-resource-paragraphs

# Conflicts:
#	composer.lock
#	composer.log
#	web/themes/custom/digital_gov/digital_gov.theme
Adds a twig function templates can use to determine logo to use for a given URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants