Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated catalog reference to fix resolved profiles and CI errors #545

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

david-waltermire
Copy link
Member

@david-waltermire david-waltermire commented Jan 11, 2024

Committer Notes

PR #542 used the incorrect OSCAL catalog URL. The OSCAL profile resolver silently ignored the bad URL, generating resolved profiles with no control content. This updates the catalog references to point to the correct resource, resulting in fully resolved catalogs containing the correct controls.

This also fixes the validation testing errors caused by the profile issues.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@david-waltermire david-waltermire requested a review from a team as a code owner January 11, 2024 23:44
@rpalmer-gsa rpalmer-gsa self-assigned this Jan 12, 2024
Copy link

@rpalmer-gsa rpalmer-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Concur additional QA testes are needed to avoid this in the future.

@david-waltermire david-waltermire merged commit 96303e9 into GSA:master Jan 12, 2024
7 checks passed
@david-waltermire david-waltermire deleted the fix-ci-errors branch January 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants