Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system identifier-type and FedRAMP extension namespaces - Issue 773 #774

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Oct 11, 2024

[DO NOT MERGE] Work In Progress (WIP)

Committer Notes

This ADR documents proposed options going forward for identifier-type, system attribute, and FedRAMP extension prop namespaces. This is part of issue #773 and reported issue #769

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

kyhu65867
kyhu65867 previously approved these changes Oct 17, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Clear and understandable, I especially like how you explicitly called out the http versus https distinction because that might be hard to spot initially.

@Rene2mt Rene2mt force-pushed the fedramp-identifier-type-and-namespace-adr branch from 418a86f to c4572b1 Compare October 23, 2024 21:43
@Rene2mt Rene2mt changed the title WIP ADR for system identifier-type and FedRAMP extension namespace ADR for system identifier-type and FedRAMP extension namespace Oct 23, 2024
@Rene2mt Rene2mt marked this pull request as ready for review October 23, 2024 21:59
@Rene2mt Rene2mt requested a review from a team as a code owner October 23, 2024 21:59
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rene2mt, update the checklist and I shall review, thanks in advance!

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be a contrarian here.

@Rene2mt Rene2mt changed the title ADR for system identifier-type and FedRAMP extension namespace Update system identifier-type and FedRAMP extension namespaces - Issue 773 Oct 25, 2024
Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks really good! The context and possible solutions are clear. Just some minor suggestions for readability and fixing typos.

@Rene2mt Rene2mt linked an issue Oct 31, 2024 that may be closed by this pull request
16 tasks
Rene2mt and others added 4 commits October 31, 2024 14:46
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Ship it!

@wandmagic
Copy link
Collaborator

lets get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align prop and misc identifier requirements for the official FedRAMP namespace
5 participants