-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system identifier-type and FedRAMP extension namespaces - Issue 773 #774
base: develop
Are you sure you want to change the base?
Update system identifier-type and FedRAMP extension namespaces - Issue 773 #774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Clear and understandable, I especially like how you explicitly called out the http versus https distinction because that might be hard to spot initially.
418a86f
to
c4572b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rene2mt, update the checklist and I shall review, thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be a contrarian here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks really good! The context and possible solutions are clear. Just some minor suggestions for readability and fixing typos.
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Ship it!
lets get it |
[DO NOT MERGE] Work In Progress (WIP)
Committer Notes
This ADR documents proposed options going forward for
identifier-type
,system
attribute, and FedRAMP extensionprop
namespaces. This is part of issue #773 and reported issue #769All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.