Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is unique inventory assets #887

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 12, 2024

Committer Notes

add is unique check for inventory assets

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner November 12, 2024 14:21
@wandmagic wandmagic changed the base branch from master to develop November 12, 2024 14:21
@wandmagic wandmagic mentioned this pull request Nov 12, 2024
14 tasks
@aj-stein-gsa aj-stein-gsa linked an issue Nov 12, 2024 that may be closed by this pull request
14 tasks
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this constraint and its tests are passing because we filter out the relevant upstream constraint (see https://github.com/usnistgov/OSCAL/blob/4f02dac6f698efda387cc5f55bc99581eaf494b6/src/metaschema/oscal_implementation-common_metaschema.xml#L530) referenced by usnistgov/OSCAL#2043 and removed in usnistgov/OSCAL#2044 usnistgov/OSCAL#2064 is filtered out of test result analysis logic, correct @wandmagic?

@wandmagic
Copy link
Collaborator Author

Where is #2044 ?

@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Nov 12, 2024

Where is #2044 ?

Updated, usnistgov/OSCAL#2064. See above, apologies. I edited after the first second or third submission, per our conversation.

Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraint is good, just need to update the help-url and associated documentation.

Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Willing to approve after my suggestion is resolved.

Gabeblis
Gabeblis previously approved these changes Nov 14, 2024
Gabeblis
Gabeblis previously approved these changes Nov 18, 2024
@wandmagic wandmagic dismissed stale reviews from aj-stein-gsa and Gabeblis via aeddcf1 November 18, 2024 17:41
@aj-stein-gsa aj-stein-gsa merged commit 2c0974d into GSA:develop Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constraint has-unique-asset-id
4 participants