-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is unique inventory assets #887
Is unique inventory assets #887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this constraint and its tests are passing because we filter out the relevant upstream constraint (see https://github.com/usnistgov/OSCAL/blob/4f02dac6f698efda387cc5f55bc99581eaf494b6/src/metaschema/oscal_implementation-common_metaschema.xml#L530) referenced by usnistgov/OSCAL#2043 and removed in usnistgov/OSCAL#2044 usnistgov/OSCAL#2064 is filtered out of test result analysis logic, correct @wandmagic?
Where is #2044 ? |
Updated, usnistgov/OSCAL#2064. See above, apologies. I edited after the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constraint is good, just need to update the help-url and associated documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Willing to approve after my suggestion is resolved.
src/validations/constraints/unit-tests/unique-inventory-item-asset-id-FAIL.yaml
Show resolved
Hide resolved
Co-authored-by: Gabeblis <[email protected]>
src/validations/constraints/content/ssp-unique-inventory-item-asset-id-INVALID.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/content/ssp-unique-inventory-item-asset-id-INVALID.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/content/ssp-unique-inventory-item-asset-id-INVALID.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/content/ssp-unique-inventory-item-asset-id-INVALID.xml
Outdated
Show resolved
Hide resolved
…asset-id-INVALID.xml Co-authored-by: A.J. Stein <[email protected]>
…asset-id-INVALID.xml Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
…asset-id-INVALID.xml Co-authored-by: A.J. Stein <[email protected]>
…asset-id-INVALID.xml Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
aeddcf1
Committer Notes
add is unique check for inventory assets
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.