-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Leveraged Authorization Entry
Constraints
#918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
wandmagic
previously approved these changes
Nov 20, 2024
nice work |
Gabeblis
changed the title
Add Leveraged Authorization Entry Constraints
Add Nov 20, 2024
Leveraged Authorization Entry
Constraints
Gabeblis
force-pushed
the
constraints/issue-897
branch
2 times, most recently
from
November 20, 2024 20:23
e62761b
to
0db03aa
Compare
kyhu65867
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write documentation if necessary but I think this looks good to go
src/validations/constraints/content/ssp-leveraged-authorization-has-impact-level-INVALID.xml
Show resolved
Hide resolved
wandmagic
previously approved these changes
Nov 21, 2024
Gabeblis
force-pushed
the
constraints/issue-897
branch
from
November 25, 2024 14:17
f804bc7
to
5e89395
Compare
Gabeblis
force-pushed
the
constraints/issue-897
branch
from
November 25, 2024 14:21
5e89395
to
ed97692
Compare
wandmagic
approved these changes
Nov 25, 2024
Rene2mt
approved these changes
Nov 25, 2024
kyhu65867
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Purpose
This PR aims to ensure that any leveraged authorization entries within the SSP have the required content to maintain compliance with FedRAMP standards. The constraints to validate the presence of said properties for each leveraged-authorization entry are to ensure the following:
Changes
Constraints Added
leveraged-authorization-has-authorization-type
This constraint checks that there is exactly 1 authorization-type property for each leveraged-authorization entry.
leveraged-authorization-has-impact-level
This constraint checks that there is exactly 1 impact-level property for each leveraged-authorization entry.
leveraged-authorization-has-system-identifier
This constraint checks that there is exactly 1 system-identifier property for each leveraged-authorization entry.
ssp-all-VALID.xml
was edited to include aleveraged-authorization
section to trigger the above constraints.Invalid test data files were created for each constraint to demonstrate the fail case.
pass and fail YAML files were added for each constraint.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.