Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leveraged Authorization Entry Constraints #918

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Gabeblis
Copy link

@Gabeblis Gabeblis commented Nov 20, 2024

Committer Notes

Purpose

This PR aims to ensure that any leveraged authorization entries within the SSP have the required content to maintain compliance with FedRAMP standards. The constraints to validate the presence of said properties for each leveraged-authorization entry are to ensure the following:

  • Exactly one authorization-type.
  • Exactly one package identifier.
  • Exactly one impact-level.

Changes

Constraints Added

  • leveraged-authorization-has-authorization-type
    This constraint checks that there is exactly 1 authorization-type property for each leveraged-authorization entry.

  • leveraged-authorization-has-impact-level
    This constraint checks that there is exactly 1 impact-level property for each leveraged-authorization entry.

  • leveraged-authorization-has-system-identifier
    This constraint checks that there is exactly 1 system-identifier property for each leveraged-authorization entry.

ssp-all-VALID.xml was edited to include a leveraged-authorization section to trigger the above constraints.

Invalid test data files were created for each constraint to demonstrate the fail case.

pass and fail YAML files were added for each constraint.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 20, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 20, 2024 12:49
@Gabeblis Gabeblis linked an issue Nov 20, 2024 that may be closed by this pull request
14 tasks
wandmagic
wandmagic previously approved these changes Nov 20, 2024
@wandmagic
Copy link
Collaborator

nice work

@Gabeblis Gabeblis changed the title Add Leveraged Authorization Entry Constraints Add Leveraged Authorization Entry Constraints Nov 20, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-897 branch 2 times, most recently from e62761b to 0db03aa Compare November 20, 2024 20:23
@Gabeblis Gabeblis requested a review from a team November 20, 2024 20:26
kyhu65867
kyhu65867 previously approved these changes Nov 21, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write documentation if necessary but I think this looks good to go

wandmagic
wandmagic previously approved these changes Nov 21, 2024
@Gabeblis Gabeblis requested a review from a team November 22, 2024 14:45
@Gabeblis Gabeblis dismissed stale reviews from wandmagic and kyhu65867 via f804bc7 November 25, 2024 14:14
@Gabeblis Gabeblis merged commit 57fd879 into GSA:develop Nov 26, 2024
6 checks passed
@Gabeblis Gabeblis deleted the constraints/issue-897 branch November 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSP Leveraged Authorization Entries
4 participants