Remove the profile attribute entirely

This was what was apparently breaking our Terraform actions.  I traced this to an undocumented breaking change with the AWS provider; more details can be seen here: https://discuss.hashicorp.com/t/error-error-configuring-terraform-aws-provider-failed-to-get-shared-config-profile-default/39417/2

Signed-off-by: Carlo Costino <[email protected]>

terraform/README.md

@@ -88,6 +88,8 @@ The below steps rely on you first configuring access to the Terraform state in s
     terraform plan
     ```
 
+    If the `terraform init` command fails, you may need to run `terraform init -upgrade` to make sure new module versions are picked up.
+
 1. Apply changes with `terraform apply`.
 
 1. Remove the space deployer service instance if it doesn't need to be used again, such as when manually running terraform once.

terraform/demo/providers.tf

@@ -12,7 +12,6 @@ terraform {
     key     = "api.tfstate.demo"
     encrypt = "true"
     region  = "us-gov-west-1"
-    # profile = "notify-terraform-backend"
   }
 }
 

terraform/production/providers.tf

@@ -12,7 +12,6 @@ terraform {
     key     = "api.tfstate.prod"
     encrypt = "true"
     region  = "us-gov-west-1"
-    # profile = "notify-terraform-backend"
   }
 }
 

terraform/sandbox/providers.tf

@@ -12,7 +12,6 @@ terraform {
     key     = "api.tfstate.sandbox"
     encrypt = "true"
     region  = "us-gov-west-1"
-    # profile = "notify-terraform-backend"
   }
 }
 

terraform/staging/providers.tf

@@ -12,7 +12,6 @@ terraform {
     key     = "api.tfstate.stage"
     encrypt = "true"
     region  = "us-gov-west-1"
-    # profile = "notify-terraform-backend"
   }
 }