Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ๊ตฌํ˜„ #10

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

ta2ye0n
Copy link
Contributor

@ta2ye0n ta2ye0n commented Nov 4, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค

Resolves: #9

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋กœ๊ทธ์•„์›ƒ
  • ๋ธ”๋ž™๋ฆฌ์ŠคํŠธ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๋ธ”๋ž™๋ฆฌ์ŠคํŠธ๋„ ์ ์šฉํ•ด๋ณด์•˜๋Š”๋ฐ ์ฒ˜์Œ ์ ์šฉํ•ด๋ณด๋Š”๊ฑฐ๋ผ ์ฝ”๋“œ๊ฐ€ ์‚ด์ง ์ด์ƒํ•  ์ˆ˜๋„ ์žˆ์–ด์š”
๊ทธ ์  ์œ ์˜ํ•ด์„œ ๋ด์ฃผ์„ธ์š”!!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?
  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด Resource ์„œ๋ฒ„์—๋„ ๋ฐ˜์˜๋˜์—ˆ๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@ta2ye0n ta2ye0n added the โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ label Nov 4, 2024
@ta2ye0n ta2ye0n self-assigned this Nov 4, 2024
@ta2ye0n ta2ye0n requested a review from Umjiseung as a code owner November 4, 2024 12:00
@ta2ye0n ta2ye0n linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ธ”๋ž™๋ฆฌ์ŠคํŠธ๋ฅผ ์ ์šฉํ•œ ์ด์œ ๊ฐ€ ๋ฌด์—‡์ธ์ง€ ๊ถ๊ธˆํ•ด์š”

@ta2ye0n
Copy link
Contributor Author

ta2ye0n commented Nov 5, 2024

๋ธ”๋ž™๋ฆฌ์ŠคํŠธ๋ฅผ ์ ์šฉํ•œ ์ด์œ ๊ฐ€ ๋ฌด์—‡์ธ์ง€ ๊ถ๊ธˆํ•ด์š”

๋กœ๊ทธ์•„์›ƒ ํ–ˆ์„ ๋•Œ ํ† ํฐ์„ ๋ฐ”๋กœ ๋ฌดํšจํ™” ์‹œ์ผœ์„œ ํ† ํฐ์ด ํƒˆ์ทจ ๋˜์—ˆ์„ ๋•Œ ๋ณด์•ˆ ์ƒ ๋ฆฌ์Šคํฌ๋ฅผ ์ค„์—ฌ์ค„ ์ˆ˜ ์žˆ๋‹ค๊ณ  ํ•ด์„œ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค

Copy link

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค์Œ์— pr ์ž‘์„ฑํ•˜์‹ค๋•Œ
์–ด๋–ค ๊ธฐ์ˆ ์„ ์‚ฌ์šฉํ•˜์‹œ๊ฒŒ ๋˜๋ฉด ์™œ ์‚ฌ์šฉํ•˜๋Š”์ง€ ์•„๋‹ˆ๋ฉด ๋‹ค๋ฅธ ๊ธฐ์ˆ ๊ณผ ๋น„๊ตํ•˜์˜€์„๋•Œ ์ด์  ๋“ฑ
ํ•˜์…จ๋˜ ๊ณ ๋ฏผ๋“ค์„ ๋ฆฌ๋ทฐ๋…ธํŠธ์— ์ ์–ด์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

Comment on lines 29 to 31
public boolean deleteBlackList(String key) {
return redisBlackListTemplate.delete(key);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด ๋‘ ๋ถ€๋ถ„์€ ํ•„์š”๊ฐ€ ์žˆ์„๊นŒ ์‹ถ์Šต๋‹ˆ๋‹ค ๋ธ”๋ž™๋ฆฌ์ŠคํŠธ์—์„œ ์‚ญ์ œํ•˜๋”๋ผ๋„ access token์˜ live time์ด ์–ผ๋งˆ ๋‚จ์ง€ ์•Š์•˜๊ณ  RefreshToken๋„ ์‚ญ์ œ๋˜์—ˆ๊ธฐ ๋•Œ๋ฌธ์— login์„ ํ•˜๋Š”๊ฒŒ ์ข‹์•„๋ณด์—ฌ์š”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

46a9d0c

ํ•ด๋‹น ๋ฉ”์„œ๋“œ ์‚ญ์ œํ–ˆ์Šต๋‹ˆ๋‹ค

return redisBlackListTemplate.delete(key);
}

public boolean hasKeyBlackList(String key) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฉ”์„œ๋“œ๋ช…... ๋ญ”๊ฐ€ ๊ตฌ๋ฆฝ๋‹ˆ๋‹ค

RedisTemplate<String, Object> template = new RedisTemplate<>();
template.setValueSerializer(new StringRedisSerializer());
template.setHashValueSerializer(new StringRedisSerializer());
template.setConnectionFactory(redisConnectionFactory());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ์— template.setEnableTransactionSupport(true); ํ•˜์‹  ๋‹ค์Œ์— Service ํด๋ž˜์Šค์— @transactional ์–ด๋…ธํ…Œ์ด์…˜ ๋ถ™์—ฌ์ฃผ๋Š”๊ฒŒ ์ข‹์•„๋ณด์—ฌ์š”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4350cd3

์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@transaction์„ Config ๋ฉ”์„œ๋“œ๊ฐ€ ์•„๋‹ˆ๋ผ LogOutServiceService ํด๋ž˜์Šค์— ๋ถ™์—ฌ์ฃผ์„ธ์š”!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

916008b

์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค!

@ta2ye0n ta2ye0n merged commit 4f460b7 into develop Nov 7, 2024
1 check passed
@ta2ye0n ta2ye0n deleted the feature/9-logout-function branch November 7, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ๊ตฌํ˜„
2 participants