๐ ์๋น์ค ํํด ๊ธฐ๋ฅ #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KimTaeO
reviewed
Nov 20, 2024
src/main/java/com/gcms/v3/domain/auth/service/impl/SignInServiceImpl.java
Show resolved
Hide resolved
Comment on lines
+24
to
+25
| userRoleRepository.deleteByUser(user); | ||
| userRepository.deleteById(user.getId()); |
There was a problem hiding this comment.
๋ ๋์ค์ ์ ์ฅ๋๋ ๋ฆฌํ๋ ์ ํ ํฐ๋ ํจ๊ป ์ญ์ ํ๋ค๋ฉด ๋ ๊น๋ํ ํํด ์ฒ๋ฆฌ๊ฐ ๋ ๊ฒ ๊ฐ๋ค์
KimTaeO
reviewed
Nov 21, 2024
| .requestMatchers(HttpMethod.POST, "/v3/auth/reissueToken").authenticated() | ||
| .requestMatchers(HttpMethod.DELETE, "/v3/auth/logout").authenticated() | ||
| .requestMatchers(HttpMethod.POST, "/auth").permitAll() | ||
| .requestMatchers(HttpMethod.POST, "/auth/reissueToken").authenticated() |
There was a problem hiding this comment.
๋ฆฌํ๋ ์ ํ ํฐ์ ์ฌ๋ฐ๊ธํ๋ ค๋ฉด ์ ๊ทผ ๊ถํ์ด permitAll์ด์ด์ผ ํ์ง ์์๊น ์ถ์ด์
KimTaeO
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
์๋น์ค ํํด ๊ธฐ๋ฅ์ ๊ตฌํํ์ต๋๋ค
Resolves: #11
๐ ์์ ๋ด์ฉ
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
pr ๋ด์ฉ๊ณผ๋ ๊ด๋ จ ์์ง๋ง
template.setEnableTransactionSupport(true);์ถ๊ฐํ๊ณ ๋์ 401 NullPointException ๋ฐ์ํ์ต๋๋ค๋ฌธ์ ์ ์ด
redisRepository์@Transactional์๊ณ SignInServiceImp์ ์๋ ํธ๋์ญ์ ์ด๋ ธํ ์ด์ ์ญ์ ํ์ต๋๋คโ PR ์ฒดํฌ๋ฆฌ์คํธ
.env,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","ํ๊ฒฝ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ