Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ… #2

Merged
merged 7 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules โ€ฆ
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @Umjiseung @ta2ye0n
16 changes: 16 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: "Bug"
description: "๋ฒ„๊ทธ๊ฐ€ ์ƒ๊ฒผ์–ด์š” ๐Ÿ‘พ"
labels: ๋ฒ„๊ทธ
body:
- type: textarea
attributes:
label: Describe
description: |
[Description] ๋ฒ„๊ทธ์— ๊ด€ํ•œ ์„ค๋ช…์„ ์ ์–ด์ฃผ์„ธ์š”
placeholder: |
conflict๋‚œ๊ฑฐ ๊ทธ๋ƒฅ mergeํ•ด๋ฒ„๋ฆผ
- type: textarea
attributes:
label: Additional
description: |
[์ถ”๊ฐ€์‚ฌํ•ญ] ๋ณ„๋„๋กœ ์•Œ๋ ค์ค˜์•ผ ํ•  ์‚ฌํ•ญ์ด๋‚˜ ์ถ”๊ฐ€์‚ฌํ•ญ์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”
16 changes: 16 additions & 0 deletions .github/ISSUE_TEMPLATE/todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: "Todo"
description: "ํ•ด์•ผํ•  ๊ฒƒ์ด ์žˆ๋‚˜์š”??๐Ÿค”"
body:

- type: textarea
attributes:
label: Describe
description: |
[Description] ํ• ์ผ์˜ ์„ค๋ช…์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.
placeholder: |
ํšŒ์›๊ฐ€์ž… UI ์ž‘์„ฑ
- type: textarea
attributes:
label: Additional
description: |
[์ถ”๊ฐ€์‚ฌํ•ญ] ๋ณ„๋„๋กœ ์•Œ๋ ค์ค˜์•ผ ํ•  ์‚ฌํ•ญ์ด๋‚˜ ์ถ”๊ฐ€์‚ฌํ•ญ์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”
32 changes: 32 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
## ๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

> PR์„ ํ•˜๊ฒŒ ๋œ ๋ฌธ์ œ์ƒํ™ฉ, ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”์— ๋Œ€ํ•ด์„œ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”!
>
> ํผ๋ธ”๋ฆฌ์‹ฑ์˜ ๊ฒฝ์šฐ ์Šคํฌ๋ฆฐ์ƒท/๋™์˜์ƒ๋„ ์ถ”๊ฐ€ํ•ด์ฃผ๋ฉด ์ข‹์•„์š”!

Resolves: #{์ด์Šˆ๋ฒˆํ˜ธ}

## ๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

> PR์—์„œ ํ•œ ์ž‘์—…์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”!

## ๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

> ๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!
>
> ๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!
>
> e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

## โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

> ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

- [ ] ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. `.env`, `๋…ธ์…˜`, `README`)
- [ ] ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. `"API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”"`, `"ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”"`)
- [ ] ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
- [ ] Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
- [ ] PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?
- [ ] ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด Resource ์„œ๋ฒ„์—๋„ ๋ฐ˜์˜๋˜์—ˆ๋‚˜์š”?

## ๐ŸŽธ ๊ธฐํƒ€
27 changes: 27 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: CI

on:
push:
branches: ["master"]
pull_request:
branches: ["*"]

jobs:
CI:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: "17"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ์„œ ์ž๋ฐ” 17์„ ์‚ฌ์šฉํ•œ๋‹ค๋Š” ๊ฒƒ์€ ๊ฐœ๋ฐœ ์‹œ์—๋„ 17์„ ์‚ฌ์šฉํ•œ๋‹ค๋Š” ์ด์•ผ๊ธฐ๊ฐ€ ๋  ํ…๋ฐ.. ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ์œผ์‹ ๊ฐ€์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํŠน๋ณ„ํ•œ ์ด์œ ๋Š” ์—†๋Š”๋ฐ ์ฒ˜์Œ์— ์ƒ์„ฑํ•  ๋•Œ 17๋กœ๋ฐ–์— ์ƒ์„ฑ์ด ์•ˆ๋˜์„œ ๊ทธ๋Ÿฐ ๊ฒƒ ๊ฐ™์•„์š” ์ œ ์ƒ๊ฐ์—๋Š” 11์„ ์“ฐ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค ๋ณ„๋‹ค๋ฅธ ์ด์œ ๊ฐ€ ์—†๋‹ค๋ฉด์š”

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹จ์ˆœ ๊ถ๊ธˆ์ฆ์ด์—ˆ์Šต๋‹ˆ๋‹ค ํŽธํ•˜์‹ ๋Œ€๋กœ ์ง„ํ–‰ํ•ด์ฃผ์„ธ์š”~

distribution: "temurin"

- name: Grant execute permission for gradlew
run: chmod +x gradlew

- name: Build with Gradle
run: ./gradlew clean build -x test
20 changes: 19 additions & 1 deletion src/main/resources/application.yml
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
spring.application.name=GCMS-server-V3
spring:
datasource:
driver-class-name: ${DB_DRIVER_CLASS}
url: ${DB_URL}
username: ${DB_USER}
password: ${DB_PASSWORD}
jpa:
hibernate:
dialect: ${DB_DIALECT}
ddl-auto: update
properties:
hibernate:
format_sql: true
show-sql: true

data:
redis:
host: ${REDIS_HOST}
port: ${REDIS_PORT}
Loading