Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ ํ† ํฐ ์žฌ๋ฐœ๊ธ‰ #8

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

ta2ye0n
Copy link
Contributor

@ta2ye0n ta2ye0n commented Nov 1, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

ํ† ํฐ ์žฌ๋ฐœ๊ธ‰ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค

Resolves: #7

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ํ† ํฐ ์žฌ๋ฐœ๊ธ‰

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

์•„์ง API ๋ช…์„ธ์„œ๊ฐ€ ๋‹ค ์ž‘์„ฑ๋˜์ง€ ์•Š์•„์„œ endpoint ์ž„์˜๋กœ ์„ค์ •ํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?
  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด Resource ์„œ๋ฒ„์—๋„ ๋ฐ˜์˜๋˜์—ˆ๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@ta2ye0n ta2ye0n added the โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ label Nov 1, 2024
@ta2ye0n ta2ye0n self-assigned this Nov 1, 2024
@ta2ye0n ta2ye0n requested a review from Umjiseung as a code owner November 1, 2024 05:07
@ta2ye0n ta2ye0n linked an issue Nov 1, 2024 that may be closed by this pull request

import java.util.Optional;

public interface RefreshTokenRepository extends CrudRepository<RefreshToken, Long> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RefreshToken์˜ Id ํƒ€์ž…์€ String์ธ๋ฐ ์—ฌ๊ธฐ์— Long์œผ๋กœ ๋˜์–ด์žˆ๋„ค์š”
String์œผ๋กœ ๋ณ€๊ฒฝํ•ด ์ฃผ์„ธ์š”!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ebbcf15

์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค!

Copy link

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~

@ta2ye0n ta2ye0n merged commit c2821f7 into develop Nov 1, 2024
1 check passed
@ta2ye0n ta2ye0n deleted the feature/7-reissue-token branch November 1, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ํ† ํฐ ์žฌ๋ฐœ๊ธ‰
2 participants