Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Uncertain Resolver X the default version #3408

Merged
merged 7 commits into from
Dec 14, 2024

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Oct 23, 2024

Uncertainty is a minigame that you have to solve to make Quantum Computers actually produce computation.

In that minigame, you have to balance around 16 squares.

The way you have to balance it is by making the values very similar, the symmetry depends on the mode it gives you.

Uncertainty Resolver comes in 3 versions:

  1. Where the values are shown by blinking rate
    uncertainty1

  2. Where the values are shown by brightness
    uncertainty2

  3. Where it solves it for you, no input required

The issue is that the way the first version of uncertainty resolver represents the values makes it very difficult to see the differences, causes players to usually just randomly click the buttons until it gets solved instead of doing the minigame normally.

This replaces the resolver X recipe to the regular one,
Removes the recipe for basic resolver,
And adds deprecation warning to it.

This also makes basic resolver acts like the X version, so it shows the values by brightness level.

image
image
java_ODkgGMf4JL

Closes GTNewHorizons/GT-New-Horizons-Modpack#10374

@Dream-Master Dream-Master requested a review from a team October 23, 2024 13:38
@boubou19 boubou19 added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. Affects Balance Change affecting balance. Requires admin approval before merging. labels Oct 23, 2024
@boubou19
Copy link
Member

On the principle i like it, it'll also reduce risks of epilepsy for some players.

@chochem
Copy link
Member

chochem commented Oct 23, 2024

was blocked last time, by colen I think?

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Oct 23, 2024
@StaffiX
Copy link
Contributor Author

StaffiX commented Oct 23, 2024

I found this ticket GTNewHorizons/GT-New-Horizons-Modpack#10374 about this change, but other than that I couldn't find where it was blocked, either on discord or github

@chochem
Copy link
Member

chochem commented Oct 23, 2024

hmm maybe not a hard block but only decided against yea. I was in favor as you can see and still am but if something was already considered and decided against then discussion is certainly productive instead of just PRing :P

@boubou19
Copy link
Member

blocked or not, it clearly is helping readability of the puzzle, and makes it way more clear about what the player must do. It's not making the puzzle easier to solve, but it now is more accessible. It's plain dumb to have two different things doing the same exact thing, but with different skins.

@Connor-Colenso
Copy link
Contributor

I don't recall having an opinion on this topic @chochem

@chochem
Copy link
Member

chochem commented Oct 23, 2024

perfect

@DylanTaylor1
Copy link
Contributor

I like the idea of deprecating the "blinking speed" for the minigame, but I also like having several tiers to the uncertainty resolver. I suppose an alternate solution is to make the basic uncertainty resolver similar to the uncertainty resolver X but have more shades/hues to make it slightly more difficult. For example:

  • Basic Uncertainty Resolver: 7 Shades
  • Uncertainty Resolver X: 4 Shades
  • Uncertainty Resolution: 1 Shade

@AbdielKavash
Copy link
Member

AbdielKavash commented Oct 24, 2024

On the principle i like it, it'll also reduce risks of epilepsy for some players.

I agree with this. Even as somebody who doesn't suffer from visual sensitivity, the rapid blinking is just obnoxious to look at. Maybe if it was blinking 1-2 times per second it would be fine, but the current frequency is too much.

If we still want multiple tiers, maybe make the first tier have color shades, and the second specific numbers or symbols?

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be revisited to expand the puzzle more like others suggested, but this change on its own I think is worth taking. We can do a follow-up PR if someone wants to work on the more detailed puzzle

@serenibyss serenibyss enabled auto-merge (squash) December 14, 2024 19:32
@serenibyss serenibyss merged commit 0cdaa56 into GTNewHorizons:master Dec 14, 2024
5 checks passed
@StaffiX StaffiX deleted the uncertaintyresolver branch December 14, 2024 21:33
Nockyx pushed a commit to Nockyx/GT5-Unofficial that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Uncertainty Resolver with Uncertainty Resolver X
8 participants