Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Tin Alloy mixer recipe #3542

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Adds Tin Alloy mixer recipe #3542

merged 4 commits into from
Dec 13, 2024

Conversation

LazyFleshWasTaken
Copy link
Contributor

@LazyFleshWasTaken LazyFleshWasTaken commented Nov 23, 2024 •
edited
Loading

closes #18070 if added.

@chochem chochem added Affects Balance Change affecting balance. Requires admin approval before merging. ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. labels Nov 23, 2024
@Dream-Master
Copy link
Member

If it not override other recipe I see no issue to add it now.

@Nockyx
Copy link
Contributor

Nockyx commented Nov 23, 2024

I don't like all alloy smelter recipes receiving mixer counterparts because this makes the alloy smelter multiblock increasingly underused.

@Dream-Master
Copy link
Member

Sure if it is a shortcut or make other recipes obsolete we need discuss if it is necessary to add

@LazyFleshWasTaken
Copy link
Contributor Author

I don't like all alloy smelter recipes receiving mixer counterparts because this makes the alloy smelter multiblock increasingly underused.

Tin alloy ingots are still needed for tin alloy stuff for goodgen. This just makes it a mixer step instead of a macerator step.

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
serenibyss
serenibyss approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like all alloy smelter recipes receiving mixer counterparts because this makes the alloy smelter multiblock increasingly underused.

I agree with the sentiment, but this recipe is very low impact for alloy smelter, and just provides a nicer way to make goodgen alloys, so I see no issue with it. I'll leave it open for a second review, if anyone objects

@Dream-Master
Copy link
Member

Lets add it

@Dream-Master Dream-Master enabled auto-merge (squash) December 13, 2024 18:05
@Dream-Master Dream-Master merged commit 67592b6 into GTNewHorizons:master Dec 13, 2024
5 checks passed
@LazyFleshWasTaken LazyFleshWasTaken deleted the Tin-alloy-mixer-recipe branch December 15, 2024 03:47
Dream-Master pushed a commit that referenced this pull request Dec 15, 2024
@LazyFleshWasTaken @Dream-Master
Adds Tin Alloy mixer recipe (#3542)
72fcf2f 
Co-authored-by: Martin Robertz <[email protected]>
(cherry picked from commit 67592b6)
@Ableytner Ableytner mentioned this pull request Dec 16, 2024
Closed
3 tasks
Nockyx pushed a commit to Nockyx/GT5-Unofficial that referenced this pull request Dec 17, 2024
@LazyFleshWasTaken @Dream-Master @Nockyx
Adds Tin Alloy mixer recipe (GTNewHorizons#3542)
78b3f45 
Co-authored-by: Martin Robertz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
Affects Balance Change affecting balance. Requires admin approval before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixer recipe for Tin Alloy
5 participants
@LazyFleshWasTaken @Dream-Master @Nockyx @serenibyss @chochem