Feat: #315 TeamCoworker, TeamCoworkerForm 타입 재정의

[Seok93]

PR Type

What kind of change does this PR introduce?

• [Feat] 새로운 기능을 추가했어요.

Related Issues

• close 팀원 목록 조회 API에 가입 대기 여부 값 추가 #315

What does this PR do?

• TeamCoworker, TeamCoworkerForm 타입 재정의

[coderabbitai]

Walkthrough

이 풀 리퀘스트는 팀원 목록 조회 API에 가입 대기 여부(isPendingApproval) 속성을 추가하는 변경 사항을 포함하고 있습니다. 주요 변경 사항은 TeamCoworker 타입에 새로운 부울 속성을 도입하고, 서비스 핸들러와 타입 정의를 업데이트하여 팀원의 승인 상태를 반영하는 것입니다.

Changes

파일	변경 요약
src/mocks/services/teamServiceHandler.ts	팀원 목록 응답에 isPendingApproval 속성 추가
src/services/teamService.ts	함수 문서 주석 업데이트 및 설명 개선
src/types/TeamType.tsx	TeamCoworker 타입에 isPendingApproval 속성 추가, TeamCoworkerForm 타입 업데이트

Assessment against linked issues

목표	해결 여부	설명
팀원 목록 조회 API에 가입 대기 여부 값 추가 [#315]	✅
TeamCoworker, TeamCoworkerForm 타입 재정의 [#315]	✅

Possibly related PRs

• Refactor: #310 MSW 처리중 teamService 기능 리팩토링 #312: 승인 대기 중인 사용자 필터링 로직 추가와 관련된 변경 사항

Suggested labels

🛠️ Refactor

Suggested reviewers

• Yoonyesol
• ice-bear98

Poem

🐰 팀원의 승인, 이제 알 수 있네
대기 상태를 속성으로 담아내네
코드는 흐르고 정보는 빛나네
협업의 길을 함께 열어가네 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a990cd and 42075cd.

📒 Files selected for processing (3)

• src/mocks/services/teamServiceHandler.ts (1 hunks)
• src/services/teamService.ts (11 hunks)
• src/types/TeamType.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/services/teamService.ts

🔇 Additional comments (3)

src/types/TeamType.tsx (2)

15-15: 승인 대기 상태를 명시하기 위한 필드 추가가 적절합니다.
새로운 isPendingApproval 프로퍼티를 통해 팀원의 승인 진행 상황을 명확하게 표현할 수 있습니다. 다른 곳에서 해당 필드를 참조할 때 타입 호환성이 올바른지 확인해주세요.

---

19-19: 폼 데이터에서 불필요한 필드 제외 처리에 동의합니다.
TeamCoworkerForm 타입에서 nickname 및 isPendingApproval를 제외해, 폼에서 불필요한 값이 제어되지 않도록 한 점이 합리적으로 보입니다.

src/mocks/services/teamServiceHandler.ts (1)

272-272: 팀원 목록 조회 시 승인 대기 상태도 함께 반환하도록 한 점이 유용합니다.
프론트엔드에서 팀원의 승인 여부를 표시할 수 있게 되어 사용자 경험을 향상할 수 있습니다. 추가 로직이 필요한 부분(예: 승인 대기 중인 사용자 표시나 별도 관리)이 있다면 논의 후 반영을 고려해주세요.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Yoonyesol]

타입 재정의도 하고 주석 포맷도 살짝 변경하셨네요ㅋㅋㅋ 요즘 리팩토링 해주셔서 코드가 더 깔끔해지고 있는 것 같아요! 이번 작업도 고생 많으셨습니다~!

[Seok93]

@Yoonyesol 리뷰 감사합니다!