Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/ should not be part of the include path #600

Closed
luishfonseca opened this issue Sep 27, 2023 · 1 comment · Fixed by #603
Closed

src/ should not be part of the include path #600

luishfonseca opened this issue Sep 27, 2023 · 1 comment · Fixed by #603
Assignees
@luishfonseca
Labels
A-Meta B-Build Related to the build configuration C-Code-Quality A section of code that is hard to understand or change
Milestone
0.0.1 Nursery

Comments

@luishfonseca
Copy link
Contributor

luishfonseca commented Sep 27, 2023 •
edited
Loading

Description

Files such as glfw_window.cpp include private headers with right angle brackets full paths, this is misleading. All private headers should be included with relative paths.

With this change, src/ could be removed from the include path
@luishfonseca luishfonseca added C-Code-Quality A section of code that is hard to understand or change A-Meta B-Build Related to the build configuration labels Sep 27, 2023
@luishfonseca luishfonseca added this to the 0.0 Nursery milestone Sep 27, 2023
@RiscadoA
Copy link
Member

Issue 600 wow

@luishfonseca luishfonseca self-assigned this Sep 27, 2023
@luishfonseca luishfonseca linked a pull request Sep 27, 2023 that will close this issue
Remove src/ from include path #603
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luishfonseca luishfonseca

Labels
A-Meta B-Build Related to the build configuration C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging a pull request may close this issue.

Remove src/ from include path GameDevTecnico/cubos
2 participants
@RiscadoA @luishfonseca