-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests fail after upgrading ember-auto-import
#113
Comments
@alexlafroscia perhaps you have seen something like this before with |
is this still an issue? |
I believe so, there are a bunch of tests which are currently being skipped: https://github.com/GavinJoyce/ember-headlessui/search?q=issues%2F113 |
Thanks for the PRs @bertdeblock! I think I know why tests sometimes fail locally. If you click in the browser while the tests are running, it's possible to get tests to fail. eg. If you click the "Hide passes tests" while the tests are executing, you might get a failure like this: |
Same goes for tests that rely on an element being in focus and the test container is hidden. Happened in this project as well I think. I've created a PR over in |
is this issue still a problem? |
The failures seem to be related to https://github.com/alexlafroscia/qunit-wait-for:
So that we're not blocking to the move to Ember 4.0, I'm going to disable the tests for now. We can either fix the issue and reenable, or rewrite the tests to no use
assert.waitFor
.The text was updated successfully, but these errors were encountered: