Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests fail after upgrading ember-auto-import #113

Open
GavinJoyce opened this issue Nov 21, 2021 · 6 comments
Open

Some tests fail after upgrading ember-auto-import #113

GavinJoyce opened this issue Nov 21, 2021 · 6 comments

Comments

@GavinJoyce
Copy link
Owner

The failures seem to be related to https://github.com/alexlafroscia/qunit-wait-for:

Screenshot 2021-11-21 at 14 16 34

So that we're not blocking to the move to Ember 4.0, I'm going to disable the tests for now. We can either fix the issue and reenable, or rewrite the tests to no use assert.waitFor.

@GavinJoyce
Copy link
Owner Author

@alexlafroscia perhaps you have seen something like this before with ember-wait-for?

@GavinJoyce GavinJoyce added internal Internal changes that still require a mention in the changelog/release notes and removed internal Internal changes that still require a mention in the changelog/release notes labels Nov 21, 2021
@NullVoxPopuli
Copy link
Collaborator

is this still an issue?

@GavinJoyce
Copy link
Owner Author

I believe so, there are a bunch of tests which are currently being skipped: https://github.com/GavinJoyce/ember-headlessui/search?q=issues%2F113

@GavinJoyce
Copy link
Owner Author

Thanks for the PRs @bertdeblock!

I think I know why tests sometimes fail locally. If you click in the browser while the tests are running, it's possible to get tests to fail. eg. If you click the "Hide passes tests" while the tests are executing, you might get a failure like this:

Screenshot 2021-12-20 at 09 27 02

@bertdeblock
Copy link
Contributor

Same goes for tests that rely on an element being in focus and the test container is hidden. Happened in this project as well I think. I've created a PR over in ember-qunit that should resolve this:
emberjs/ember-qunit#912

@NullVoxPopuli
Copy link
Collaborator

is this issue still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants