upgrade ember-auto-import #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinJoyce
force-pushed
the
gj/upgrade-auto-import
branch
from
ff38a06
to
cb267a8
Compare
GavinJoyce
force-pushed
the
gj/upgrade-auto-import
branch
from
1f4e5bf
to
74c2e3c
Compare
GavinJoyce
added
the
internal
This was referenced Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #95
So as to not block getting this addon ready for ember 4, I'm temporarily skipping tests that were failing with
t is not a functionerrors #113. We can reenable them once we've figured our the cause