Use tag-name-is-component helper to remove need for Menu::ItemElement backing class
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { helper } from '@ember/component/helper'; | ||
|
|
||
| function tagNameIsComponent([as]) { | ||
| return typeof as === 'object'; |
There was a problem hiding this comment.
do we want this to return true for things that aren't components?
There was a problem hiding this comment.
Technically no, but it would be weird for someone to pass an object that isn't a component.
Perhaps there are some other things we could check for on the object? If not, I think this is likely good enough for now.
There was a problem hiding this comment.
I mean, this is a quick win, we can make it more constrained later as the public API declares what is intended anyway
NullVoxPopuli
approved these changes
Oct 3, 2021
GavinJoyce
changed the title
tag-name-is-component helpertag-name-is-component helper to remove need for Menu::ItemElement backing class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #77 (comment)
This removes the need for the
Menu::ItemElementcomponent to have a backing class.An existing test is covering this: 83796b3#diff-2f1746c8a31c717bfe0069265e1afc57117088ae1761e4a498ecaa6ebc325897R157