Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link Component #39

Merged
merged 10 commits into from
Oct 22, 2020
Merged

Add Link Component #39

merged 10 commits into from
Oct 22, 2020

Conversation

mcmontseny
Copy link
Contributor

Add Link Component #7

@mcmontseny mcmontseny requested review from d-asensio and a team October 17, 2020 21:23
Copy link
Collaborator

@d-asensio d-asensio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a small thing to change ;)

src/components/Link/Link.vue Outdated Show resolved Hide resolved
src/components/Link/Link.vue Outdated Show resolved Hide resolved
@mcmontseny mcmontseny requested a review from d-asensio October 20, 2020 21:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@d-asensio d-asensio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,42 @@
<template>
<h5>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this h5

@d-asensio d-asensio merged commit 2921a98 into GeeksCAT:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants