Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cc 13 collection management components #32

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

hmcclew
Copy link
Contributor

@hmcclew hmcclew commented Oct 12, 2023

Description

Created components that perform the following functionality using mocked tsx types:
Collection Management:
Collection list: list of collections with buttons to edit/delete
CollectionItem: Single Collection in the list
Collection form: form to create/edit a collection
GiftSelector: dropdown component with ability to add gifts to a collection

Fixes # (issue)

How Has This Been Tested?

tested in my browser on port 5173 to ensure desired functionality

Checklist:

  • [X ] I have performed a self-review of my code
  • [ X] I have reached out to another developer to review my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [ X] New and existing unit tests pass locally with my changes

@hmcclew hmcclew requested a review from matherg October 12, 2023 14:51
@hmcclew hmcclew linked an issue Oct 12, 2023 that may be closed by this pull request
Copy link
Contributor

@matherg matherg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Great starting point we can build off of later when we get a lo-fi from the design team. Only change is this: instead of having a list of strings for "gift", create a gift type that matches the backend type. I like only displaying the names of gifts, it makes the ui clean and still has enough info for Cait to know whats going on. So create a gift type, and then display the names of the gifts just like you are already doing.

@matherg matherg force-pushed the cc-13-collection-management-components branch from 7dcc73c to 9fc8507 Compare October 17, 2023 22:20
@matherg matherg merged commit 86d1df1 into main Oct 17, 2023
1 of 3 checks passed
@matherg matherg deleted the cc-13-collection-management-components branch November 7, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC-13: Collection Management Components
2 participants