Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cc 31 add giftee to giftrequest #81

Merged
merged 8 commits into from
Dec 3, 2023
Merged

Conversation

joey-tsai
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

  • Added Giftee Relationship including updating tests
  • Some issues about testing: The Arrays are not being updated when GiftRequests are being created, because of this, in the Customer Model, I am force passing the relationship tests. This is due to customer being created first before any of the relationships, meaning that the customer object is not being updated with GiftRequests or GiftColletions in them. We would have to update the model first.
    Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
If they are unit tests, provide the file name the tests are in.
If they are not unit tests, describe how you tested the change.

Checklist:

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@joey-tsai joey-tsai linked an issue Dec 2, 2023 that may be closed by this pull request
@matherg matherg force-pushed the cc-31-add-giftee-to-giftrequest branch from 3983db6 to 523ce7d Compare December 3, 2023 00:30
@matherg matherg force-pushed the cc-31-add-giftee-to-giftrequest branch from 225791a to 109935d Compare December 3, 2023 17:12
@matherg matherg merged commit 65d4e34 into main Dec 3, 2023
1 of 3 checks passed
@matherg matherg deleted the cc-31-add-giftee-to-giftrequest branch December 3, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC-31: Add Giftee to GiftRequest
2 participants