refactor! #20
Merged
refactor! #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattchris
requested review from
CamPlume1,
jtrrll,
alderwhiteford and
garrettladley
garrettladley
requested changes
Sep 23, 2024
| @@ -22,7 +23,11 @@ func RouteHelloGroup(app *fiber.App, config *config.Config) { | |||
| unprotected := app.Group("/hello") | |||
|
|
|||
| //Endpoints | |||
| protected.Get("/world", hello.RetHelloWorld) | |||
| unprotected.Get("/world", hello.RetHelloWorld) | |||
| protected.Get("/world", func(c *fiber.Ctx) error { | |||
There was a problem hiding this comment.
if you create a struct with the db as a field, you can simplify this.
struct example
register route example
| ) | ||
|
|
||
| func RetHelloWorld(ctx *fiber.Ctx) error { | ||
| func RetHelloWorld(ctx *fiber.Ctx, db *pgx.Conn) error { |
There was a problem hiding this comment.
by doing the struct field approach, you will resolve this error. also, is this really a "transaction"? i would consider this a handler.
garrettladley
changed the title
abyan-n
pushed a commit
that referenced
this pull request
Sep 24, 2024
* pass databse down to backend routes * fix db error return * Co-authored-by: Garrett Ladley <[email protected]> * Co-authored-by: Garrett Ladley <[email protected]> * lint fxes
abyan-n
pushed a commit
that referenced
this pull request
Sep 25, 2024
* pass databse down to backend routes * fix db error return * Co-authored-by: Garrett Ladley <[email protected]> * Co-authored-by: Garrett Ladley <[email protected]> * lint fxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Link to Ticket](insert the link to your ticket inside the parenthesis here)
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.
Checklist