Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete/venue review #34

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Conversation

abyan-n
Copy link
Collaborator

@abyan-n abyan-n commented Sep 30, 2024

Description

[Link to Ticket](insert the link to your ticket inside the parenthesis here)

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
https://trello.com/c/H37iULmB/19-delete-api-venues-reviews-reviewid

Added a delete endpoint to delete a review for a venue.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

Postman, checked with valid ID, invalid ID, invalid path params.

Checklist

  • [X ] I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] New and existing unit tests pass locally with my changes

Copy link
Collaborator

@CamPlume1 CamPlume1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small notes:

  1. Combine Interface is the blocking change here. Deleting legacy comment would be a nice bonus 👍

backend/internal/handlers/venues/routes.go Outdated Show resolved Hide resolved
backend/internal/storage/storage.go Show resolved Hide resolved
Copy link
Collaborator

@wyattchris wyattchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface change resolved

backend/internal/storage/storage.go Show resolved Hide resolved
@wyattchris wyattchris dismissed CamPlume1’s stale review October 1, 2024 17:03

Change resolved

@wyattchris wyattchris merged commit dcc8960 into main Oct 1, 2024
3 checks passed
@wyattchris wyattchris deleted the feature/delete/venue_review branch October 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants