Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Route Refactor #140

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Nested Route Refactor #140

merged 2 commits into from
Feb 2, 2024

Conversation

garrettladley
Copy link
Member

@garrettladley garrettladley commented Feb 2, 2024

CI will fail due to tests not being updated to accommodate auth.

@akshayd2020 refactored as follows:

C: POST api/v1/tags/
R: GET api/v1/tags/:id
U: PATCH api/v1/tags/:id
D: DELETE api/v1/tags/:id

R: GET api/v1/categories/:categoryID/tags/
R: GET api/v1/categories/:categoryID/tags/:tagID

@garrettladley garrettladley requested review from a team February 2, 2024 20:57
@garrettladley garrettladley requested review from akshayd2020, in-mai-space and DOOduneye and removed request for a team February 2, 2024 20:57
Copy link
Contributor

@DOOduneye DOOduneye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@garrettladley garrettladley merged commit 6e25748 into main Feb 2, 2024
4 of 5 checks passed
@garrettladley garrettladley deleted the nested-route-refactor branch February 2, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants