Finished follower endpoints #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mai Nguyen <[email protected]>
zacklassetter
force-pushed
the
SAC-26-Follower-CRUD
branch
from
bdcafb4 to
aff5bb7
Compare
DOOduneye
reviewed
Feb 4, 2024
| } | ||
|
|
||
| func (cf *ClubFollowerController) GetUserFollowingClubs(c *fiber.Ctx) error { | ||
| clubs, err := cf.clubFollowerService.GetUserFollowingClubs(c.Params("userID")) |
There was a problem hiding this comment.
this value changes for everyone, we should standardize this value, especially as the middleware just checks for "id' @garrettladley @zacklassetter @in-mai-space
| } | ||
|
|
||
| func (uf *UserFollowerController) CreateFollowing(c *fiber.Ctx) error { | ||
| err := uf.userFollowerService.CreateFollowing(c.Params("userID"), c.Params("clubID")) |
| @@ -48,7 +48,7 @@ type User struct { | |||
|
|
|||
| Tag []Tag `gorm:"many2many:user_tags;constraint:OnUpdate:CASCADE,OnDelete:CASCADE;" json:"-" validate:"-"` | |||
| Member []Club `gorm:"many2many:user_club_members;constraint:OnUpdate:CASCADE,OnDelete:CASCADE;" json:"-" validate:"-"` | |||
| Follower []Club `gorm:"many2many:user_club_followers;constraint:OnUpdate:CASCADE,OnDelete:CASCADE;" json:"-" validate:"-"` | |||
| Follower []Club `gorm:"many2many:user_club_followers;constraint:OnUpdate:CASCADE,OnDelete:CASCADE;" json:"clubs_followed,omitempty" validate:"-"` | |||
There was a problem hiding this comment.
do we want to send a list of followers? or should it only be passed when requested? might be unnecessary information
backend/src/server/server.go
Outdated
| @@ -119,6 +135,17 @@ func clubRoutes(router fiber.Router, clubService services.ClubServiceInterface, | |||
| clubsID.Get("/", clubController.GetClub) | |||
| clubsID.Patch("/", middlewareService.Authorize(types.ClubWrite), clubController.UpdateClub) | |||
| clubsID.Delete("/", middlewareService.Authorize(types.ClubDelete), clubController.DeleteClub) | |||
| clubs.Get("/:id", clubController.GetClub) | |||
There was a problem hiding this comment.
why define these endpoints?
| } | ||
|
|
||
| // Get all following for a user | ||
|
|
| return &errors.ClubNotFound | ||
| } | ||
| // What to return here? | ||
| // Should we return User or Success message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SAC-26
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.
We manually tested all of the endpoints and wrote unit tests
Checklist