Added nitro to the frameworks #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costinsin
reviewed
Jul 24, 2024
Implemented the changes suggested by Costin
docs/frameworks/nitrojs.md
Outdated
| 1. You might need to replace the `path` field with the path relative at **genezio.yaml** file. | ||
| 2. This example configuration works if **genezio.yaml** is in the same directory as your main application file. | ||
| ::: | ||
| ## 3. Test Your App Locally |
There was a problem hiding this comment.
Isn't this already said starting with line 98?
There was a problem hiding this comment.
It is, but we are also doing this in the express doc, and I thought it was something we wanted. IMO if we delete one it should for sure be the one in lines 98, but I also see some value in having both, as a way for someone who is creating his first nitro app from scratch to acknowledge that it is working, before doing anything Genezio related.
Release Refine Tutorial
Fixed some typos
Add Fastify and other small improvs
…rted Feature/new getting started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should first wait for genezio to be added to nitro in the following days, before pushing to prod. Just an initial draft.