Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an External Application only possible from catalogue view #1

Open
mkrueger-dev opened this issue Apr 22, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@mkrueger-dev
Copy link

Hi,
I implemented the feature and noticed that you can only access the "External Application" in the "Add Resource" dropdown from the catalogue view, but not from the base path.

Cheers,
Marcus

@gannebamm gannebamm added the enhancement New feature or request label Apr 22, 2024
@ridoo
Copy link
Member

ridoo commented Apr 22, 2024

I noticed this some time ago, but did not find out the reason for that directly. Thanks for reporting, so we have it documented.

@ridoo
Copy link
Member

ridoo commented Jun 13, 2024

Adding some thought: The app actually does not add itself to the drop down menu. This is done by the geonode-mapstore-client. Perhaps there's some location where to add another config of externalapplication in the localConfig.json. However, did not explore further yet.

Edit: The blueprint adds the drop down entry for externalapplications for the catalogue plugin only.

@ridoo
Copy link
Member

ridoo commented Jun 13, 2024

Could be that the geonode-mapstore-client does not consider the overrides from _geonode_config.html, when starting from /. I suspect geonode_mapstore_client/templates/index.html:

<script>
    window.addEventListener('mapstore:ready', function(event) {
        const catalogPagePath = window.__GEONODE_CONFIG__.localConfig.geoNodeSettings.catalogPagePath;
        const pagePath = catalogPagePath ? catalogPagePath : '/catalogue/';
        const msAPI = event.detail;
        msAPI.setPluginsConfig([
            {
                name: 'FeaturedResourcesGrid',
                cfg: {
                    targetSelector: '#gn-home-featured-resources-grid',
                    pagePath: pagePath
                }
            },
            {
                name: 'ResourcesGrid',
                cfg: {
                    targetSelector: '#gn-home-resources-grid',
                    containerSelector: '#gn-home-resources-grid',
                    pagination: false,
                    pagePath: pagePath,
                    disableFilters: true,
                    disableDetailPanel: true,
                    enableGeoNodeCardsMenuItems: true
                }
            },
            { name: 'SaveAs', cfg: { closeOnSave: true } },
            { name: 'DeleteResource' },
            { name: 'DownloadResource' },
            { name: 'Notifications' }
        ]);
    });
</script>

@ridoo
Copy link
Member

ridoo commented Dec 4, 2024

Had a deeper look into it and it seems to be an upstream issue: GeoNode/geonode-mapstore-client#1916

I could not find a workaround for now, so let's see what geosolutions replies. The only workaround I see for now is to add the menu item directly to the ResourceGrid menuItems default parameter list (in case you maintain you own fork of geonode-mapstore-client).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants