Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plurigaussian fields #370

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Plurigaussian fields #370

wants to merge 20 commits into from

Conversation

LSchueler
Copy link
Member

Plurigaussian simulations (PGS) are a great way to easily increase the flexibility of Gaussian random fields. With this PR I want to directly incorporate them into GSTools. It not only includes the implementation, but also unittests and a few examples, with which users can familiarize themselves with PGS, as I do not find them very intuitive at first.

However, I still have a few open questions:

  • Should PGS really be a class? I mostly did this for GSTools to keep a more or less constant structure. But I don't see any benefits of using a class here. It only makes it a bit more complicated to use PGSs, as you have to first create an instance and then call it, instead of only calling a pgs function. Any opinion on this point @MuellerSeb ?

  • At one point we might have to think about a new structure for the examples. In 01_random_field we have examples for general field generation, but based on the randomization method and some examples showing the Fourier method. Then we have 04_vector_field with the vector field generation. And now we have 11_plurigaussian. What do you think @MuellerSeb , should we discuss this soon?

  • Is the argument facies the best name for a method which is used in many different fields?

  • Any other paper(s) we should cite?

@LSchueler LSchueler added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2024
@LSchueler LSchueler added this to the 1.7 milestone Nov 19, 2024
@LSchueler LSchueler self-assigned this Nov 19, 2024
I'm not able to install old numpy versions locally and the exception
documentation of numpy is non existent and I can't bother to go through
its source code, so I'll just see what the actions show.
I don't understand why `np.AxisError` doesn't work for np 2.x
@LSchueler
Copy link
Member Author

LSchueler commented Nov 20, 2024

Wow, that's a curious detail I stumbled upon...

And for some reason, the old numpy.AxisError didn't work for me with numpy 2.x, which was moved to numpy.exceptions.AxisError, but for backwards compatibility was supposed to be kept in the old place too.

Comment on lines +74 to +77
try:
np.AxisError = np.exceptions.AxisError
except AttributeError:
...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants