A whole bunch of pylint warning/error/refactor fixes #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This PR is pretty big, it's a LOT of small fixes all throughout the whole code base. Probably can't be reviewed in one sitting (take your time, go through one file at a time). Thankfully, it's all low risk minor changes.
This PR is specifically intended to address hundreds of pylint warnings/errors & convention guidelines to bring the PyRate code base into a more standardised set of coding paradigms & conventions.
This PR should have absolutely zero impact on processing outcomes, the code should run exactly as it did before this PR.
The primary reason for this is to enable PyRate to use pylint as an additional QA mechanism to keep the quality of the code base maintainable and less prone to error, which will help future refactors (eg: cleaning up shared.py / configuration.py / etc) by giving us an extra tool to ensure we haven't done something wrong / haven't forgotten something.
Before this PR:
After this PR:
The remaining errors/warnings I left in are legitimate problems, however out of scope (or I lack the context/PyRate-knowledge) to fix them immediately (best done in their own PRs).