Add addMesh() #21
Merged
Add addMesh() #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eg: addBox(group/box) will add box to 'group'. Refactor _parse_entity()
- Use entity_path_prefix to transmit entity_path to external data loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, in external data loader, only
filepathandentity_path_prefixare transmitted.So here, I use
entity_path_prefixto transmit the actualentity_pathto the data loader, so that it logs the file as 'entity_path_prefix'.See dataloader : Gepetto/rerun-loader-collada@main...EtaLoop:rerun-loader-collada:entity-path
I have opened an issue about the possibility of adding
entity_pathtolog_file_from_path.See : rerun-io/rerun#8364