extend and document PublishOption (#872)

* extend and document PublishOption * fix bitrate
GetStream · Nov 28, 2024 · 5c38190 · 5c38190
1 parent 5ce5d7a
commit 5c38190
Show file tree

Hide file tree

Showing 6 changed files with 801 additions and 735 deletions.
diff --git a/protobuf/video/sfu/event/events.pb.go b/protobuf/video/sfu/event/events.pb.go
diff --git a/protobuf/video/sfu/event/events.proto b/protobuf/video/sfu/event/events.proto
@@ -77,9 +77,8 @@ message SfuEvent {
     ParticipantUpdated participant_updated = 24;
     // ParticipantMigrationComplete is sent when the participant migration is complete
     ParticipantMigrationComplete participant_migration_complete = 25;
-    // CodecNegotiationComplete is sent to signal the completion of a codec negotiation.
-    // SDKs can safely stop previous transceivers
-    CodecNegotiationComplete codec_negotiation_complete = 26;
+    // ChangePublishOptionsComplete is sent to signal the completion of a ChangePublishOptions request.
+    ChangePublishOptionsComplete change_publish_options_complete = 26;
     // ChangePublishOptions is sent to signal the change in publish options such as a new codec or simulcast layers
     ChangePublishOptions change_publish_options = 27;
   }
@@ -89,12 +88,10 @@ message ChangePublishOptions {
   models.PublishOption publish_option = 1;
 }
 
-message CodecNegotiationComplete {
-
+message ChangePublishOptionsComplete {
 }
 
 message ParticipantMigrationComplete{
-
 }
 
 message PinsChanged {

diff --git a/protobuf/video/sfu/event/events_vtproto.pb.go b/protobuf/video/sfu/event/events_vtproto.pb.go