fix: undefined values in query params (#1187)

Followup fix for d2ff8ec Url params with undefined values need to be excluded from param serialization logic, since stream backend doesn't treat `undefined` same as param not being present.
GetStream · Oct 19, 2023 · a325737 · a325737
1 parent a4d18fd
commit a325737
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -250,6 +250,10 @@ export function removeConnectionEventListeners(cb: (e: Event) => void) {
 export const axiosParamsSerializer: AxiosRequestConfig['paramsSerializer'] = (params) => {
   const newParams = [];
   for (const k in params) {
+    // Stream backend doesn't treat "undefined" value same as value not being present.
+    // So, we need to skip the undefined values.
+    if (params[k] === undefined) continue;
+
     if (Array.isArray(params[k]) || typeof params[k] === 'object') {
       newParams.push(`${k}=${encodeURIComponent(JSON.stringify(params[k]))}`);
     } else {

diff --git a/test/unit/utils.js b/test/unit/utils.js
@@ -77,6 +77,7 @@ describe('axiosParamsSerializer', () => {
 				a: 1,
 				b: 2,
 				c: null,
+				d: undefined,
 			},
 			output: 'a=1&b=2&c=null',
 		},
-Original file line number
+Diff line change
@@ Expand Up / @@ -77,6 +77,7 @@ describe('axiosParamsSerializer', () => { @@
     				a: 1,
     				b: 2,
     				c: null,
+    				d: undefined,
     			},
     			output: 'a=1&b=2&c=null',
     		},
@@ Expand Down @@