Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support privacy settings #1283

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

@kanat kanat changed the title (real-time-indicators) support privacy settings feat: support privacy settings Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

Size Change: +627 B (0%)

Total Size: 369 kB

Filename Size Change
dist/browser.es.js 79.6 kB +136 B (0%)
dist/browser.full-bundle.min.js 48.2 kB +87 B (0%)
dist/browser.js 80.6 kB +134 B (0%)
dist/index.es.js 79.6 kB +135 B (0%)
dist/index.js 80.6 kB +135 B (0%)

compressed-size-action

oliverlaz
oliverlaz previously approved these changes Apr 26, 2024
Copy link
Member

@oliverlaz oliverlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -692,6 +698,10 @@ export class Channel<StreamChatGenerics extends ExtendableGenerics = DefaultGene
} as Event<StreamChatGenerics>);
}

_isTypingIndicatorsEnabled(): boolean {
return this.getClient().user?.privacy_settings?.typing_indicators?.enabled ?? true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move !this.getConfig()?.typing_events check here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@vishalnarkhede vishalnarkhede merged commit f16552b into master Apr 30, 2024
5 of 6 checks passed
@vishalnarkhede vishalnarkhede deleted the feature/real-time-indicators branch April 30, 2024 14:51
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants