Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix channel.membership type #1300

Merged
merged 6 commits into from
May 16, 2024
Merged

fix: fix channel.membership type #1300

merged 6 commits into from
May 16, 2024

Conversation

myandrienko
Copy link
Contributor

We had a separate type for channel.membership which seemed to be incomplete and different from the type of channel.members[i].

In this PR:

  1. Replace ChannelMembership type with ChannelMemberResponse everywhere, since it's supposed to be the same type (see backend types: [1] and [2]).
  2. Keep ChannelMembership for reverse compatibility, but deprecate it and make it an alias for ChannelMemberResponse.

Copy link
Contributor

github-actions bot commented May 16, 2024

Size Change: +73 B (+0.02%)

Total Size: 369 kB

Filename Size Change
dist/browser.es.js 79.6 kB +17 B (+0.02%)
dist/browser.js 80.6 kB +20 B (+0.02%)
dist/index.es.js 79.6 kB +17 B (+0.02%)
dist/index.js 80.7 kB +19 B (+0.02%)
ℹ️ View Unchanged
Filename Size
dist/browser.full-bundle.min.js 48.2 kB

compressed-size-action

szuperaz
szuperaz previously approved these changes May 16, 2024
@myandrienko myandrienko force-pushed the fix/channel-membership branch from b2b95cd to 311858f Compare May 16, 2024 12:38
@myandrienko myandrienko requested a review from szuperaz May 16, 2024 12:52
@myandrienko myandrienko merged commit 367cc20 into master May 16, 2024
5 of 6 checks passed
@myandrienko myandrienko deleted the fix/channel-membership branch May 16, 2024 12:53
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants