-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thread manager bugs #1372
Merged
arnautov-anton
merged 8 commits into
master
from
fix/reset-thread-manager-on-disconnect
Nov 11, 2024
Merged
fix: thread manager bugs #1372
arnautov-anton
merged 8 commits into
master
from
fix/reset-thread-manager-on-disconnect
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isekovanic
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
September 27, 2024 06:28
isekovanic
changed the title
Fix/reset thread manager on disconnect
fix: thread manager bugs
Sep 27, 2024
Size Change: +737 B (+0.16%) Total Size: 457 kB
|
6 tasks
myandrienko
approved these changes
Oct 7, 2024
MartinCupela
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
This PR fixes 2 leftover issues in Threads v2:
ThreadManager
state being stale after logging out in an appThreadManager
stateChangelog