Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark optional types as optional #170

Closed
wants to merge 1 commit into from
Closed

Mark optional types as optional #170

wants to merge 1 commit into from

Conversation

ngieseker
Copy link
Contributor

@ngieseker ngieseker commented May 21, 2024 •
edited
Loading

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

IAT and EXP should be marked as optional parameters.

@ngieseker ngieseker requested a review from gumuz as a code owner May 21, 2024 21:34
@totalimmersion totalimmersion requested review from totalimmersion and 10printhello and removed request for gumuz September 4, 2024 13:40
@totalimmersion
Copy link
Contributor

We've added these changes as part of another PR, therefor I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totalimmersion totalimmersion totalimmersion approved these changes

@10printhello 10printhello Awaiting requested review from 10printhello 10printhello is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngieseker @totalimmersion