Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused file #2258

Merged
merged 1 commit into from
Oct 20, 2023
Merged

refactor: remove unused file #2258

merged 1 commit into from
Oct 20, 2023

Conversation

tao-qian
Copy link
Contributor

🎯 Goal

It doesn't seem like this useChatClient.ts is referenced anywhere. The one that's used is here:

stream-chat-react-native/examples/SampleApp/src/hooks/useChatClient.ts

Line 67 in 17d8fa6

export const useChatClient = () => {

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

haresh12
haresh12 approved these changes Oct 18, 2023
View reviewed changes
Copy link

@haresh12 haresh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go with it

@vishalnarkhede vishalnarkhede changed the title Remove unused file refactor: remove unused file Oct 19, 2023
@vishalnarkhede vishalnarkhede merged commit bae308e into GetStream:develop Oct 20, 2023
3 of 4 checks passed
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haresh12 haresh12 haresh12 approved these changes

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tao-qian @stream-ci-bot @vishalnarkhede @haresh12