Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with String.replaceAll being undefined function #2271

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: issue with String.replaceAll being undefined function #2271

merged 1 commit into from
Oct 20, 2023

Conversation

vishalnarkhede
Copy link
Contributor

🎯 Goal

Fixes: #2253

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@vishalnarkhede vishalnarkhede merged commit af9050a into develop Oct 20, 2023
6 checks passed
@vishalnarkhede vishalnarkhede deleted the fix/replace-all-function branch October 20, 2023 08:39
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 approved these changes

@santhoshvai santhoshvai Awaiting requested review from santhoshvai

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: mentionUserString.replaceAll is not a function. After update to 5.18.1
3 participants
@vishalnarkhede @stream-ci-bot @khushal87