Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support refreshing photo selection on iOS #2291

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Nov 8, 2023

🎯 Goal

fixes #2240

🛠 Implementation details

use relevant methods from cameraroll and expo

🎨 UI Changes

IMG_5433490AA109-1

🧪 Testing

Give limited permissions on iOS. This button should appear.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@khushal87
Copy link
Member

Screenshot 2023-11-09 at 10 37 30 AM
On iOS. This could be because you forgot to add the handler on expo-package/src/index.js

Copy link
Member

@khushal87 khushal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Figma, there is also this Alert which shows two buttons, Select more photos and Change settings buttons. Can we have that or we ignore the change settings?

@santhoshvai
Copy link
Member Author

According to Figma, there is also this Alert which shows two buttons, Select more photos and Change settings buttons. Can we have that or we ignore the change settings?

This is a good point.. but I fear that the alert needs a lot of texts and translations

And this will be stuck. We can do that later in my view.

Manage Library for example.. when translated.. it directly means that we are managing a book library

We don't have translations support as well.. So taking the middle ground here

@khushal87 khushal87 merged commit 5613dfd into develop Nov 9, 2023
6 checks passed
@khushal87 khushal87 deleted the support-refresh-limited-ios branch November 9, 2023 09:41
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Unable to change photos available to attachment picker after dismissing initial dialog
3 participants