Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change filename and fileSize to name and size respectively for Asset type #2329

Merged
merged 1 commit into from
Nov 23, 2023
Merged

refactor: change filename and fileSize to name and size respectively for Asset type #2329

merged 1 commit into from
Nov 23, 2023

Conversation

khushal87
Copy link
Member

🎯 Goal

Currently, the key for file name and size are filename and fileSize. We change it to name and size so that it stays in line with the Asset type.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@khushal87 khushal87 merged commit 2567900 into develop Nov 23, 2023
6 checks passed
@khushal87 khushal87 deleted the fix-asset-type branch November 23, 2023 17:08
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshvai santhoshvai santhoshvai approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushal87 @stream-ci-bot @santhoshvai