fix: report correct package version in the source code #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
oliverlaz,
myandrienko and
arnautov-anton
|
Size Change: -69 B (-0.01%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2566 +/- ##
==========================================
- Coverage 83.23% 83.22% -0.01%
==========================================
Files 439 438 -1
Lines 9142 9140 -2
Branches 2237 2237
==========================================
- Hits 7609 7607 -2
Misses 1205 1205
Partials 328 328 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
oliverlaz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Report the correct package version in
useChat.tshook.🛠 Implementation details
During the release process the correct latest package version can be determined only while
semantic-releaseis run. This is becausesemantic-releaseinfers the next version. The bundle script now takes into consideration theNEXT_VERSIONenv variable value set during thesemantic-releaseprocess run. If this value is not set, then the version is calculated from the current latest git tag - that is useful for local builds. Otherwise the fallback is package.jsonversionthat is not maintained, but such fallback should actually be never executed.We are removing the
version.tsfile andcopy-version.shscript as this script was run before the version could be calculated.