Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement onAllPermissionsGranted for rememberCallPermissionsState #1045

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

skydoves
Copy link
Member

Implement onAllPermissionsGranted for rememberCallPermissionsState.

This solution resolves #1026 by utilizing the onAllPermissionsGranted lambda to detect when all necessary permissions are granted, enabling us to proceed with joining the call.

CallContent(
    permissions = rememberCallPermissionsState(
        call = call,
        onAllPermissionsGranted = {
            call.join()
        }
    ),
  ..
)

@skydoves skydoves self-assigned this Mar 21, 2024
@skydoves skydoves requested a review from a team as a code owner March 21, 2024 04:56
Copy link
Collaborator

@aleksandar-apostolov aleksandar-apostolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we'll have to consolidate all the various ways we have that tell us if the permissions are granted or not.
But this one fits nice with the rememberCallPermissionsState

@aleksandar-apostolov aleksandar-apostolov merged commit 928cc7e into develop Mar 21, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/permission-improvements branch March 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on apps targeting Android 14 (Unable to start foreground service)
2 participants