-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use device ringtone for incoming call sound #1179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviu-timar
force-pushed
the
PBE-5920-use-device-ringtone
branch
4 times, most recently
from
September 16, 2024 13:20
a543571
to
1f0b12a
Compare
liviu-timar
force-pushed
the
PBE-5920-use-device-ringtone
branch
from
September 16, 2024 13:23
1f0b12a
to
5d8ef1e
Compare
aleksandar-apostolov
requested changes
Sep 17, 2024
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/Sounds.kt
Outdated
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/Sounds.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt
Outdated
Show resolved
Hide resolved
liviu-timar
force-pushed
the
PBE-5920-use-device-ringtone
branch
7 times, most recently
from
September 18, 2024 10:23
5059361
to
04e08ff
Compare
liviu-timar
force-pushed
the
PBE-5920-use-device-ringtone
branch
from
September 18, 2024 10:23
04e08ff
to
9e0ed94
Compare
aleksandar-apostolov
requested review from
aleksandar-apostolov
and removed request for
aleksandar-apostolov
September 24, 2024 10:50
aleksandar-apostolov
approved these changes
Sep 24, 2024
aleksandar-apostolov
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Refactor sound configuration. Add possibility to use device ringtone for incoming call sound.
🛠 Implementation details
SoundConfig
interface to be used inSounds
constructor.Sounds
constructor.SoundConfig
:createDeviceRingtoneSoundConfig
,createStreamResourcesSoundConfig
,createEmptySoundConfig
.createCustomSoundConfig
.🧪 Testing
Cases:
Sounds
inBuilder
: outgoing - default tone provided by SDK, incoming - device ringtone.Sounds
constructor: marked as deprecated & using passed sounds.Sounds
property: the custom sound will be used.null
toSounds
property: that sound will be disabled (muted).null
: fallback to default SDK incoming sound.READ_EXTERNAL_STORAGE
permission:RingtoneManager.getActualDefaultRingtoneUri()
will evaluate tonull
, fallback as above.🎉 GIF