Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug info #1181

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove debug info #1181

merged 2 commits into from
Sep 19, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

The DebugInfo has been making more trouble than it was worth having. Removing it for now. We will create a new Profiler class in the future to allow us having debugging and timing info in the future.

🛠 Implementation details

Removed the Timer and DebugInfo classes. Also removed developmentMode boolean in StreamVideoClientIml.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner September 17, 2024 13:17
skydoves
skydoves approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) I like this cleaning

@aleksandar-apostolov aleksandar-apostolov merged commit 18c5057 into develop Sep 19, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the remove_debug_info branch September 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandar-apostolov @skydoves