Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in StreamCallActivity and demo-app #1184

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Improvements in StreamCallActivity and demo-app #1184

merged 3 commits into from
Sep 19, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

@aleksandar-apostolov aleksandar-apostolov commented Sep 18, 2024 •
edited
Loading

🎯 Goal

  1. Improve the StreamCallActivity to be able to better handle onConfigurationChange without destroying the call or entering PiP.
  2. Add a wake-lock to hold the screen on if this is configured in the intent.
  3. Add additional controls in the landscape menu to allow for chat access and settings.

@aleksandar-apostolov
Add more controls in landscape, configurationChange is no longer co…
8356cdb 
…nsidered a destructive action to `leave` the call. Add wake lock when a call is ongoing.
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner September 18, 2024 16:39
@aleksandar-apostolov aleksandar-apostolov changed the title Improvements in StreamCallActivity Improvements in StreamCallActivity and demo-app Sep 18, 2024
skydoves
skydoves approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

demo-app/src/main/kotlin/io/getstream/video/android/ui/call/CallScreen.kt Outdated Show resolved Hide resolved
This was linked to issues Sep 19, 2024
Demo app: Rotating device breaks call #1157
Closed
Ringing tutorial demo app: Changing orientation resets call each time #1159
Closed
@aleksandar-apostolov aleksandar-apostolov merged commit fa526e8 into develop Sep 19, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the prevent_screen_off_when_in_call branch September 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ringing tutorial demo app: Changing orientation resets call each time Demo app: Rotating device breaks call
2 participants
@aleksandar-apostolov @skydoves