Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE 6044] Device switch improvements #1191

Merged
merged 4 commits into from
Sep 26, 2024
Merged

[PBE 6044] Device switch improvements #1191

merged 4 commits into from
Sep 26, 2024

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Sep 25, 2024 •
edited
Loading

🎯 Goal

Improve device switching and Dashboard settings reading.

🛠 Implementation details

  • Removed MediaManager preferSpeakerphone ctor parameter.
  • Reading selectedDevice.value in both enabled & disabled cases in MediaManager#setSpeakerPhone.

@liviu-timar liviu-timar requested a review from a team as a code owner September 25, 2024 14:56
@liviu-timar liviu-timar mentioned this pull request Sep 25, 2024
Closed
@aleksandar-apostolov aleksandar-apostolov linked an issue Sep 26, 2024 that may be closed by this pull request
Call Settings for custom call type are not applied to a call #1173
Closed
@aleksandar-apostolov aleksandar-apostolov merged commit ba29ce4 into develop Sep 26, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the PBE-6044-device-switch-improvements branch September 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call Settings for custom call type are not applied to a call
2 participants
@liviu-timar @aleksandar-apostolov