Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE 6041] Fix incoming call PN issue #1197

Merged

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Oct 3, 2024

🎯 Goal

Fix issue that makes incoming call PN to not be delivered after user logs-out and a new user logs-in.

🛠 Implementation details

  • Always re-assign the Retrofit API instance when installing StreamNotificationManager so that the correct user token is used in the AuthInterceptor for CreateDevice and DeleteDevice requests.
  • Register the push device only after getting connection.ok event to avoid race-condition between VideoConnect and CreateDevice.
  • Fix the Demo App by calling deleteDevice at log-out.

🧪 Testing

  • Sign in with a user and see if it receives incoming call PN.
  • Sign out then sign in again with another user. The new user should also get the PN and be able to accept the call.
  • Can be done in the Demo App or in the Audio Call Sample.

@liviu-timar liviu-timar requested a review from a team as a code owner October 3, 2024 12:28
@liviu-timar liviu-timar marked this pull request as draft October 4, 2024 12:49
@liviu-timar liviu-timar marked this pull request as ready for review October 4, 2024 13:57
@aleksandar-apostolov aleksandar-apostolov merged commit 6c62e6a into develop Oct 7, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the PBE-6041-fix-incoming-call-notification-issue branch October 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants