Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlacklistAwareVideoDecoderFactory #1204

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Add BlacklistAwareVideoDecoderFactory #1204

merged 5 commits into from
Oct 16, 2024

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Oct 16, 2024

🎯 Goal

Slack:

This PR includes 3 changes:

  • it adds BlacklistAwareVideoDecoderFactory to fix the issue with decoding VP9 on exynos-related processors (for instance Google Pixel 7 uses exynos HW decoders)
  • it add hooks for built-in users to login with app_key we need
  • it fixes the absence of video for livestream calls

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

Copy link
Member

@liviu-timar liviu-timar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to test the sw decoder, as I don't have an appropriate phone:

I revived an old Samsung J6 phone with an Exynos chipset. It uses a hw decoder for VP8, but it switches to a sw decoder (libvpx) for VP9.

But:

  • The demo app credentials changes work well, was able to login to a different env. 👍
  • The layout change for audio/video calls in StreamCallActivity works. 👍

@liviu-timar liviu-timar marked this pull request as ready for review October 16, 2024 10:54
@liviu-timar liviu-timar requested a review from a team as a code owner October 16, 2024 10:54
@kanat kanat enabled auto-merge (squash) October 16, 2024 14:53
@kanat kanat merged commit ebd1c70 into develop Oct 16, 2024
7 checks passed
@kanat kanat deleted the fix/livestream branch October 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants