Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-153] ForegroundServiceStartNotAllowedException will now show the notification instead of failing the whole process of starting a service #1239

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

Sometimes starting a foreground service from the notification may fail on higher android versions. In this case we just show the notification and delay the service for when the UI is visible.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner December 2, 2024 11:04
@aleksandar-apostolov aleksandar-apostolov changed the title Start service crash [AND-153] Start service crash Dec 2, 2024
@aleksandar-apostolov aleksandar-apostolov changed the title [AND-153] Start service crash [AND-153] ForegroundServiceStartNotAllowedException will now show the notification instead of failing the whole process of starting a service Dec 2, 2024
Copy link
Member

@liviu-timar liviu-timar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and a "clean up" commit.

@aleksandar-apostolov aleksandar-apostolov merged commit bb9c515 into develop Dec 4, 2024
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the start-service-crash branch December 4, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForegroundServiceStartNotAllowedException: Sometimes incoming call notification is not shown
2 participants