Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-152] Fix missing floating window due to missing local track #1241

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

Fix the issues where the local track would be missing thus not showing the floating participant window.

🛠 Implementation details

  1. The me flow now also attempts to map me based on the isLocal flag instead of just the session id.
  2. When SFU connects we wait a bit for the state to settle before calling onConnected and starting the connectRtc flow.

🧪 Testing

How to reproduce (inconsistent):

  • Join a call by scanning a QR code.
  • When joined if the floating window is visible leave the call immediately.
  • Repeat above steps repeatedly until the floating video is missing (usually 1/10 times on my Pixel 7)

After the fix, I haven't encountered the issue on the Pixel 7 anymore i.e. I did 10 cycles of the above steps and the floating video would always show.

…`, update `me` based on the `isLocal` if its null, use `collectAsStateWithLifecycle` on `me` flow
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner December 2, 2024 16:30
@aleksandar-apostolov aleksandar-apostolov merged commit 4ef5c01 into develop Dec 6, 2024
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the and-152-fix-floating-window-missing branch December 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants