Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-21] Closed Caption in demo app #1252

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[AND-21] Closed Caption in demo app #1252

wants to merge 6 commits into from

Conversation

rahul-lohra
Copy link
Contributor

🎯 Goal

Implement Closed captions in demo app

  1. User is able to show and hide closed captions
  2. If closed is not running at the moment from backend then, then a user can invoke startClosedCaptions Rest End Point
  3. The Closed Captions toggle UI is present in the 3 dots bottom menu

Describe why we are making this change

🛠 Implementation details

Describe the implementation

Please look here: https://link.excalidraw.com/l/3pA6EEutKdi/3MEczcJqlaE

🎨 UI Changes

Add relevant screenshots

Before After
image image
image image
-------- -------
-------- -------

Add relevant videos

Before After

🧪 Testing

Explain how this change can be tested (or why it can't be tested)

Provide a patch below if it is necessary for testing

Provide the patch summary here 
Provide the patch code here

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@rahul-lohra rahul-lohra self-assigned this Dec 13, 2024
@rahul-lohra rahul-lohra requested a review from a team as a code owner December 13, 2024 09:54
@rahul-lohra
1. Expose CC start and stop Rest Apis
6994458 
2. Create its response model
3. Create WS events and map it
4. Add CaptionManager to handle cc relates properties
5. Update closedCaptionMode data type in TranscriptionSettingsResponse
6. Add closedCaptionUi argument
@rahul-lohra
Closed Captions Demo-app implementation
df1b6cf
@rahul-lohra rahul-lohra force-pushed the feature/rahullohra/closed_caption_demo_app branch from 1f2535c to df1b6cf Compare December 17, 2024 11:55
@rahul-lohra
1. Expose CC start and stop Rest Apis
d09a77a 
2. Create its response model
3. Create WS events and map it
4. Add CaptionManager to handle cc relates properties
5. Update closedCaptionMode data type in TranscriptionSettingsResponse
6. Add closedCaptionUi argument
7. Update UT
@rahul-lohra
Merge branch 'feature/rahullohra/expose_cc_apis' into feature/rahullo…
7927385 
…hra/closed_caption_demo_app
@rahul-lohra
Add comments
c5a8414
@rahul-lohra
Merge branch 'refs/heads/feature/rahullohra/expose_cc_apis' into feat…
63ddc39 
…ure/rahullohra/closed_caption_demo_app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rahul-lohra rahul-lohra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rahul-lohra